Update cors.md to allow CORS for websockets #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vektah
reviewed
Aug 7, 2019
docs/content/recipes/cors.md
Outdated
| upgrader := websocket.Upgrader{ | ||
| CheckOrigin: func(r *http.Request) bool { | ||
| // Check against your desired domains here | ||
| return true |
There was a problem hiding this comment.
probably should read something like:
return r.Host == "example.org"defaulting to true is a huge security hole, as it allows any domain to open websockets to your graph.
|
No worries @vektah, I've changed it. |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Update cors.md to allow CORS for websockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cors.md file did not cover websockets in particular. I have updated the example in the cors.md file to show how this is done.