Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config option to omit pointers to slice elements #874

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Add config option to omit pointers to slice elements #874

merged 1 commit into from
Sep 24, 2019

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Sep 24, 2019

To help compatibility with prisma there is now a setting in config to omit_slice_element_pointers: true which will generate []Thing instead of []*Thing everywhere.

fixes #738

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@vektah vektah merged commit b43edf5 into master Sep 24, 2019
@vektah vektah deleted the configurable-slice-element-pointers branch September 24, 2019 10:58
@vektah vektah mentioned this pull request Oct 1, 2019
Closed
@vektah vektah mentioned this pull request Nov 13, 2020
Closed
@frederikhors frederikhors mentioned this pull request Dec 4, 2020
Closed
@iamjenechka iamjenechka mentioned this pull request Mar 11, 2022
Closed
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#874 from 99designs/configurable-slice-el…
1168eb9 
…ement-pointers

Add config option to omit pointers to slice elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolver returning type to be a slice of structs
1 participant
@vektah