Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicitly exclude trailing comma from link #982

Merged
merged 1 commit into from
Jan 7, 2020
Merged

fix: explicitly exclude trailing comma from link #982

merged 1 commit into from
Jan 7, 2020

Conversation

DavidJFelix
Copy link
Contributor

  • this looks dumb, but when the page is rendered, the link resolves with the comma, despite the comma being excluded in github rendering.

@DavidJFelix
fix: explicitly exclude trailing comma from link
ac67050 
- this looks dumb, but when the page is rendered, the link resolves with the comma, despite the comma being excluded in github rendering.
@DavidJFelix
Copy link
Contributor Author

image

Inspect on current page

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.145% when pulling ac67050 on DavidJFelix:patch-1 into 4e95b36 on 99designs:master.

@vektah vektah merged commit 28c032d into 99designs:master Jan 7, 2020
@DavidJFelix DavidJFelix deleted the patch-1 branch January 8, 2020 00:57
@DavidJFelix DavidJFelix restored the patch-1 branch January 8, 2020 00:57
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#982 from DavidJFelix/patch-1
d49d0a2 
fix: explicitly exclude trailing comma from link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidJFelix @coveralls @vektah