go.mod: use forked go-keychain #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the go modules (go.mod) to directly use the forked 99designs/go-keychain repository, instead of requiring keybase/go-keychain and then using the replace directive. The reasoning for this is because the replace directive does not propagate to projects which depend on the go-keychain project. This means other projects which depend on the go-keychain project still need to add their own replace directive. Removing the replace directive from this project means that consumers will automatically get the 99designs/go-keychain indirect dependency. If there is a conflict with another indirect dependency on keybase/go-keychain then that project can decide whether to replace one or the other dependency.
This was referenced Jan 19, 2022
|
@mtibben Any chance of merging this? |
|
Thank you! |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
I think this also fixes #93
This updates the go modules (go.mod) to directly use the forked 99designs/go-keychain repository, instead of requiring keybase/go-keychain and then using the replace directive. The reasoning for this is because the replace directive does not propagate to projects which depend on the go-keychain project. This means other projects which depend on the go-keychain project still need to add their own replace directive. Removing the replace directive from this project means that consumers will automatically get the forked 99designs/go-keychain indirect dependency.
The only case where I see this possibly causing a problem would be a project which depends on 99designs/keyring and also depends on another project which depends on the upstream keybase/go-keychain. But even in that case, I believe go would just treat them as two separate packages and just include them both.