Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixing problems with spaces in url #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

🐛 Fixing problems with spaces in url #29

wants to merge 2 commits into from

Conversation

Vmadmax
Copy link

@Vmadmax Vmadmax commented Dec 3, 2018

Fixing problems with spaces in url.
See this old closed pull request: #21

@mpdude
Copy link

mpdude commented Dec 3, 2018

Why don’t you just urlencode the entire URL before passing it along to Thumbor?

@mpdude
Copy link

mpdude commented Dec 5, 2018

Maybe you could check if webfactory#1 (webfactory/phumbor: ^1.2.3 on Composer) helps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vmadmax @mpdude