plan9/client: make ReadAt compatible with io.ReaderAt interface #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satisfy this requirement of io.ReaderAt:
When ReadAt returns n < len(p), it returns a non-nil error
explaining why more bytes were not returned.
In other words, when EOF is reached and 0 < n < len(p), io.EOF error
must be returned. ReadAt was delaying sending io.EOF until n == 0.
Satisfying io.ReaderAt makes it possible to substitute Fid with os.File
in Plan 9.
fhs
added a commit
to fhs/9fans-go
that referenced
this pull request
Oct 9, 2018
Depends on PR 9fans#26 for consistent behavior of ReadAt. Helps rjkroege/edwood#115
Closed
fhs
added a commit
to fhs/9fans-go
that referenced
this pull request
Sep 19, 2019
Depends on PR 9fans#26 for consistent behavior of ReadAt. Helps rjkroege/edwood#115
ddevault
pushed a commit
to ddevault/9fans-go
that referenced
this pull request
Sep 21, 2019
Depends on PR 9fans#26 for consistent behavior of ReadAt. Helps rjkroege/edwood#115
fhs
added a commit
to fhs/9fans-go
that referenced
this pull request
May 12, 2020
Depends on PR 9fans#26 for consistent behavior of ReadAt. Helps rjkroege/edwood#115
anton2920
pushed a commit
to anton2920/9fans-go
that referenced
this pull request
Apr 25, 2023
Depends on PR 9fans#26 for consistent behavior of ReadAt. Helps rjkroege/edwood#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfy this requirement of io.ReaderAt:
In other words, when EOF is reached and 0 < n < len(p), io.EOF error
must be returned. ReadAt was delaying sending io.EOF until n == 0.
Satisfying io.ReaderAt makes it possible to substitute Fid with os.File
in Plan 9.