This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Tradecommit #96
Merged
Tradecommit #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t when check_unchecked_msgs flag is set to True
DavoudTaghawiNejad
force-pushed
the
tradecommit
branch
from
972dc41 to
641bae4
Compare
rht
approved these changes
Sep 11, 2017
rht
reviewed
Sep 11, 2017
| @@ -84,9 +82,9 @@ def consumption(self): | |||
| utility = self.consume_everything() | |||
| assert is_zero(utility - 10 ** 0.2 * 10 ** 0.5 * 10 ** | |||
| 0.3), (utility, 10 ** 0.2 * 10 ** 0.5 * 10 ** 0.3) | |||
| assert self.possession('a') == 0 | |||
There was a problem hiding this comment.
This will be hard to port to other language. I suggest to use self.possession.
There was a problem hiding this comment.
True, but in this case I prefer to keep it nice in python and find more awkward springs in other languages later. We don't even know if another language will happen or not.
There was a problem hiding this comment.
For a standard of an economic simulation library, yes it will be in multiple languages.
There was a problem hiding this comment.
Ok in this case let's give both options. I will make a pioneered which does not depreciate possessions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.