-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
185 ship schema with package #189
Conversation
Also flagged a couple of spots where more 'correct' package data importing should be used
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
- Coverage 96.96% 96.95% -0.02%
==========================================
Files 9 9
Lines 626 623 -3
==========================================
- Hits 607 604 -3
Misses 19 19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and pinged Jo and Tommy for comments.
Let me know when you want another review @marc-white |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some commented code to delete.
This PR closes #185 by incorporating the schema descriptions (JSON) into the package. This has been done IAW what I think is current best practice for storing & loading data files within a package (https://docs.python.org/3/library/importlib.resources.html#module-importlib.resources).
Whilst doing this, I found a couple of places where the
data
submodule was doing some ad-hoc local data loads. These have also been updated to use the new pattern.Open questions: