Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata locations for existing CMIP5 and CMIP6 experiments #205

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

marc-white
Copy link
Collaborator

Closes #200 .

New metadata.yaml have been placed in /g/data/xp65/admin/intake/metadata/, and referenced in the catalog config YAMLs.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (e67d2ba) to head (97694fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files           9        9           
  Lines         623      623           
=======================================
  Hits          604      604           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/cmip5.yaml Outdated Show resolved Hide resolved
config/cmip6.yaml Outdated Show resolved Hide resolved
config/cmip6.yaml Outdated Show resolved Hide resolved
config/cmip5.yaml Outdated Show resolved Hide resolved
@rbeucher
Copy link
Member

What about we copy that metadata folder to the repo?

Copy link
Collaborator Author

@marc-white marc-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about we copy that metadata folder to the repo?

Which metadata folder is that? If you're talking about what's now in /g/data/xp65/admin/intake/metadata, I'd be against that - we'd then have a mish-mash of some experiment metadata.yaml being in the data store, and some being in the access-nri-intake-catalog. As a general proposition, the metadata should live with the data.

That being said, given the config YAMLs that define the catalog sources are kept in the repository as an 'archive' (the build_all script needs to be pointed to a checked-out copy of the repo to access them), there is an argument to be made that storing a copy of the experiment metadata.yamls archivally in the repository makes sense. Copies would still need to live in the data store, or in /g/data/xp65/admin/intake/metadata, for use during catalog build.

@rbeucher
Copy link
Member

I agree that the metadata.yml files should be stored alongside the data. However, when adding the NCI data collections to the datastore, we don't have write access to those projects. As there will be additional collections (see other data requests I’ve submitted), I propose keeping a copy of the metadata.yml files in the repository for reference.

…github.com:ACCESS-NRI/access-nri-intake-catalog into 200-missing-metadata-files-for-existing-catalogues
@marc-white
Copy link
Collaborator Author

I agree that the metadata.yml files should be stored alongside the data. However, when adding the NCI data collections to the datastore, we don't have write access to those projects. As there will be additional collections (see other data requests I’ve submitted), I propose keeping a copy of the metadata.yml files in the repository for reference.

I've added reference copies of the YAMLs to the repository.

@rbeucher
Copy link
Member

Great. Feel free to merge

@marc-white marc-white merged commit 06a9d42 into main Sep 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing metadata.yaml files for existing CMIP5 & CMIP6 catalogues
2 participants