-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata locations for existing CMIP5 and CMIP6 experiments #205
Update metadata locations for existing CMIP5 and CMIP6 experiments #205
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 9 9
Lines 623 623
=======================================
Hits 604 604
Misses 19 19 ☔ View full report in Codecov by Sentry. |
What about we copy that metadata folder to the repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about we copy that metadata folder to the repo?
Which metadata folder is that? If you're talking about what's now in /g/data/xp65/admin/intake/metadata
, I'd be against that - we'd then have a mish-mash of some experiment metadata.yaml
being in the data store, and some being in the access-nri-intake-catalog
. As a general proposition, the metadata should live with the data.
That being said, given the config
YAMLs that define the catalog sources are kept in the repository as an 'archive' (the build_all script needs to be pointed to a checked-out copy of the repo to access them), there is an argument to be made that storing a copy of the experiment metadata.yaml
s archivally in the repository makes sense. Copies would still need to live in the data store, or in /g/data/xp65/admin/intake/metadata
, for use during catalog build.
I agree that the metadata.yml files should be stored alongside the data. However, when adding the NCI data collections to the datastore, we don't have write access to those projects. As there will be additional collections (see other data requests I’ve submitted), I propose keeping a copy of the metadata.yml files in the repository for reference. |
…github.com:ACCESS-NRI/access-nri-intake-catalog into 200-missing-metadata-files-for-existing-catalogues
I've added reference copies of the YAMLs to the repository. |
Great. Feel free to merge |
Closes #200 .
New
metadata.yaml
have been placed in/g/data/xp65/admin/intake/metadata/
, and referenced in the catalogconfig
YAMLs.