-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
199 data request 20km regional projections for cordex cmip6 queensland future climate science #219
base: main
Are you sure you want to change the base?
Conversation
* Replaced a couple of try/excepts with .get in `src/access_nri_intake/catalog/translators.py` * Updated a misleading docstring
…nate variable searching & indexing
… searching for coordinate variables
likely to be necessary for passing around coordinates as well as data variables as we begin to make coordinates indexable - I think we'll begin to get confused about what belongs where.
dataclasses that are fed into a dataclass holding all the coordinate and data variables from a netCDF file. - Updated tests so that they are all passing: tests now expect to find coordinate variables from the netCDF files as well as data variables. - Some minor changes to make code more readable - changed long tuples to dataclasses & dictionaries where possible.
…due to use of '|' type union syntax - might be worth consideration? - Removed a couple of unused imports, cleaned up some comments
… search (forgot to test)
- Updated tests to better respect moving coordinate variables back into variables - Moved mypy setup stuff into to 'pre-commit-config.yaml'
…gional-projections-for-cordex-cmip6-queensland-future-climate-science Most interested in keeping typing hanging around for development speed.
…portant, causing unnecessary test failures)
…NRI/access-nri-intake-catalog into 660-coordinate-variables
…ex.yaml and config/metadata_sources/cordex-ig45/metadata.yaml
…al-projections-for-cordex-cmip6-queensland-future-climate-science
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
- Coverage 96.95% 96.89% -0.06%
==========================================
Files 9 9
Lines 623 644 +21
==========================================
+ Hits 604 624 +20
- Misses 19 20 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charles-turner-1 there isn't a convention for naming the metadata sources that we're storing in the repository. This is a very recent change that was made to avoid repeating issues like #200. However, they're only reference copies, and the catalog itself should reference the metadata.yaml
stored somewhere on /g/data
. Therefore, you can really do what you like with this, so long as we stay internally consistent.
frequency: | ||
- | ||
variable: | ||
- | ||
nominal_resolution: | ||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just leave these as blank-blank, rather than a blank array.
related_experiments: | ||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
config/cmip6.yaml
Outdated
- metadata_yaml: /g/data/xp65/admin/intake/metadata/cmip6_ig45/metadata.yaml | ||
path: | ||
- /g/data/ig45/catalog/v2/esm/catalog.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the path where the 'live' metadata.yaml
is being stored, then I'd recommend the reference copy's name/path within the repo match, i.e. be cmip6_ig45
.
|
||
sources: | ||
|
||
- metadata_yaml: /g/data/xp65/admin/access-nri-intake-catalog/config/metadata_sources/cordex-ig45/metadata.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a path where we want to be storing live YAML
... see discussion on #200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it currently stands, it looks like you're going to load the same Intake-ESM catalogue into access-nri-intake-catalog
twice, using two different translators and metadata.yaml
files. I presume you wanted to use the cordex
ones in the final merge?
sentry) - Updated cmip6.yaml as a different translator is required for Cordex experiments as main CMIP6 experiments.
f9dbb95
to
b303840
Compare
Yup - the changes to I'm not 100% sure I understand the discussion around YAML paths fully - either that or it appears we need to update a bunch of paths in |
@charles-turner-1 There's a few things about YAML paths:
|
Added Cordex CMIP6 Translators
Beginning refactoring @rbeucher noted would be useful in Add support for BARPA py18 data store #211. There's a little more work to do here so I've left this as a draft PR for now.
@marc-white You added
config/experiments/cmip6_ig45.yaml
in this branch - I've separately added aconfig/metadata_sources/cordex_ig45.yaml
which is doing largely the same thing but seemed to follow the other source conventions more closely. Are you able to confirm whether there's a convention I'm unaware of?Closes #199