Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add MOM6 support (om4 025jra ryf) #258

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

marc-white
Copy link
Collaborator

Closes #175 .

This PR adds the data requested from #175 , which required a new builder: MOM6Builder.

PR includes relevant builder, translator, and tests.

@marc-white marc-white linked an issue Nov 18, 2024 that may be closed by this pull request
5 tasks
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.38%. Comparing base (38d4c45) to head (47166db).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/access_nri_intake/source/builders.py 88.88% 3 Missing ⚠️
src/access_nri_intake/catalog/manager.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   97.90%   97.38%   -0.53%     
==========================================
  Files          11       11              
  Lines         810      840      +30     
==========================================
+ Hits          793      818      +25     
- Misses         17       22       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@charles-turner-1
Copy link
Collaborator

charles-turner-1 commented Nov 18, 2024

All tests passing - just codecov that's not passing.

I guess that must mean that CI environment isn't mirroring Gadi correctly..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

[DATA REQUEST] Add COSIMA Panantarctic / GFDL_OM4 Builder & Data
2 participants