-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic cherry-pick workflow #90
Conversation
…o another as part of a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Hope they are useful.
Note I looked at the second part with the cherry-pick machinery, but not in detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few requests. Very cool stuff in here.
@aidanheerdegen @CodeGat Thanks for the reviews! I'll update the code tomorrow. |
- Improved logic when local for wrong command syntax. - Use env variables to declare PR comments body. This removes the need to escape some characters. - Improve comments in a couple of places.
@aidanheerdegen @CodeGat I've addressed your comments in 7166e82. Let me know if you have any further comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I don't have write permissions on this repo, so my review won't help with the mergability of this PR.
As an aside, how did you test this workflow? I've found that creating a seperate org for GitHub Actions testing works well - but I'm sure you've tested it all piecewise anyway!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all (especially Micael) - looks like great work!
I'm in no position to review, but I'm happy to approve.
Okay, lets merge this and let people give it a try 🚀 |
This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there: |
This workflow allows to cherry-pick commits from a PR into a list of target branches. A new PR will be created for each target branch. This is triggered by a comment on the pull request of the following form:
cherry-pick <hash_1> <hash_2> ... <hash_n> into <branch_1> <branch_2> ... <branch_n>
Planned/missing features:
cherry-pick abcd into MOM6-CICE6-WW3/1deg_jra55do_ryf
cherry-pick abcd into MOM6-CICE6-WW3/*
Contributes to COSIMA/access-om3#119