Skip to content

Commit

Permalink
Remove optionality from dev or release regex
Browse files Browse the repository at this point in the history
  • Loading branch information
CodeGat committed Aug 9, 2024
1 parent c4d8a7d commit 8f6ff1e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/model_config_tests/qa/test_access_esm1p5_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ def __init__(self, branch_name):

def set_config_scenario(self) -> str:
# Regex below is split into three sections:
# Config type start section: '(?:release|dev)?-' for 'release-' or 'dev-'
# Config type start section: '(?:release|dev)-' for 'release-' or 'dev-'
# Scenario section: '([^+]+)' for 'preindustrial', 'historical'...anything that isn't the '+' modifier sigil
# Modifiers end section: '(?:\+.+)*' any amount of '+modifer' sections
scenario_match = re.match(

Check warning on line 49 in src/model_config_tests/qa/test_access_esm1p5_config.py

View check run for this annotation

Codecov / codecov/patch

src/model_config_tests/qa/test_access_esm1p5_config.py#L49

Added line #L49 was not covered by tests
r"^(?:release|dev)?-(?P<scenario>[^+]+)(?:\+.+)*$", self.branch_name
r"^(?:release|dev)-(?P<scenario>[^+]+)(?:\+.+)*$", self.branch_name
)
if not scenario_match or "scenario" not in scenario_match.groupdict():
pytest.fail(

Check warning on line 53 in src/model_config_tests/qa/test_access_esm1p5_config.py

View check run for this annotation

Codecov / codecov/patch

src/model_config_tests/qa/test_access_esm1p5_config.py#L52-L53

Added lines #L52 - L53 were not covered by tests
Expand Down

0 comments on commit 8f6ff1e

Please sign in to comment.