-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACCESS-ESM1.5
: QA Tests
#41
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 76.29% 73.58% -2.71%
==========================================
Files 15 15
Lines 658 723 +65
==========================================
+ Hits 502 532 +30
- Misses 156 191 +35 ☔ View full report in Codecov by Sentry. |
Note |
Might need a bit of a sanity check on the use of parameterization in the pytests. |
Tested this on Gadi with ACCESS-NRI/access-esm1.5-configs@9191fd9 |
0b420ad
to
8aa6093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soz, a couple of changes and some questions/comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…t function from `src/model_config_tests` directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve, but if you think we should make the changes to the module use path now, then feel free to do so and ask for yet another review
RELEASE_MODULE_LOCATION = "/g/data/vk83/modules/access-models" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG(reat)TM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
Add QA tests for
ACCESS-ESM1.5
to themodel-config-tests
package. Requires bump to0.0.3
when merged.In this PR:
test_*_config.py
files into newqa
directorytest_access_esm1p5_config.py
- see ACCESS-ESM1.5 testing #21 (comment)access_esm1p5
QA pytest marker0.0.3
Closes #21
Pinging @jo-basevi so she can follow along on my progress 😄