Swap to FCIS architecture #154
Merged
+124
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atteggiani
previously approved these changes
Nov 8, 2024
atteggiani
reviewed
Nov 8, 2024
atteggiani
requested review from
marc-white
and removed request for
marc-white
Co-authored-by: Marc White <mwhite1206@gmail.com>
atteggiani
force-pushed
the
145/fcis-architecture
branch
from
4b471a7
to
096659f
Compare
marc-white
approved these changes
Nov 19, 2024
atteggiani
requested review from
atteggiani and
marc-white
and removed request for
marc-white
atteggiani
approved these changes
Nov 19, 2024
marc-white
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the main section of #145. Remaining tasks will be split off into smaller issues.
This finishes off the implementation of the FCIS architecture, where IO steps are all separated into an "imperative shell", and all cube modifications are handled in the "functional core"
process_cubes()function, making the main parts of the code testable.These changes were put together over a couple of smaller steps into the feature branch
145/fcis-architecture, and the purpose of this PR is to bring the changes intomain- hence the changes may look familiar!The changes to
um2netcdf.pyinclude:cubewrite()intoprocess_cubes()cubewrite()intoprocess()cubewrite()is then deleted.The changes to
test_um2netcdf.pyare there to make the tests work with the updated structure, and were previously discussed in #148.