Improving SS as a source of truth

[quinnwai]

Problem(s)

1. pushing up to SS is prompted with make local. At “make” time, you don’t know if your secrets work yet
2. Even if we fix this and push to SS, we aren’t making use of SS as a common source of truth right now. We should test and work towards a common Secrets file to reduce the amount of local changes each individual has to make as patches made do not have to be created.
3. Even then, it is still different to see what has changed since SS doesn’t store a history of secret versions
   1. The following solutions assume that we are tied to using SS

Design/Goals

1. Create a push-secret make command which isn’t called in make local (usage make push-secrets DEPLOY=local)
2. Enable a secrets-local-test file so that we only update secrets-local with secrets-local-test once it has been tested on all of our local branches (ie make local)
   1. Ensure that the current secrets-local on SS works on all our locals
3. SSClient.py: Along with enabling above, create a description to add to each push-secret (just like commit message since there’s no versioning)
   1. Note: will not do for now, as descriptions are non-editable for each individual update to secrets

[matthewpeterkort]

yeah these are good improvements

[quinnwai]

Tried to create a description to add to each action, but the actions in the Audit (ie history tab) are not editable. Let me know if you think commit messages / descriptions are still important or if we should just leave it... code below to keep it somewhere

# edit the description for most recent update
        actions_url = f"{OHSU_SECRET_SERVER_ENDPOINT}/api/v1/secrets/{id}/audits" \
                        "?filter.Action=Update&skip=0&take=1&sort=Date&dir=desc"
        
        # TODO
        commit_msg = "DESCRIPTION"

        response = session.get(actions_url, headers=headers)
        response.raise_for_status()
        latest_update = response.json()["records"][0]
        
        if latest_update:
            update_url = f"{OHSU_SECRET_SERVER_ENDPOINT}/api/v1/audit/{latest_update['id']}"
            data = {"notes": commit_msg}
            response = session.patch(update_url, headers=headers, json=data)
            response.raise_for_status()
            print("Description updated successfully!")
        else:
            print("No 'Update' actions found in the audit history.")

        
        response = session.patch(update_url, json=data)
        data = {"Notes": commit_msg}  # Set the desired description
        print("updated commit message")