Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS testing and conditional SS update on make deploy #55

Merged
merged 6 commits into from
May 30, 2024

Conversation

quinnwai
Copy link

@quinnwai quinnwai commented May 30, 2024

Testing python SSClient.py

  • make list-secret:
    • creates a list of 10 items in the format

      id        name                  secretTemplateName    folderId
      ...
      12345     Some CBDS Secret      secretThing           1234
      ....
    • token older than 2 hrs deletes itself

    • existing token is used

    • token is generated if none exists

  • make fetch-secret ENV=local overwrites existing file using SS
  • python [SSClient.py](http://SSClient.py) token
    • Test that arguments can be passed into it (like username otp etc)
  • make local updates the Secrets-local in SS server (as shown by history of uploads in Audit tab)

Feature

Prompt to update SS when running make local or make deploy

@matthewpeterkort
Copy link
Collaborator

I suspect with the new changes you may not any longer need these lines:

gen3-helm/SSClient.py

Lines 34 to 46 in 3b57b8b

class CustomHttpAdapter (requests.adapters.HTTPAdapter):
"""Python 3.12 uses openSSL v3 which doesn't allow for
unsafe legacy renegotiation. Secretserver endpoint is
making me have to use unsafe legacy renegotiation"""
def __init__(self, ssl_context=None, **kwargs):
self.ssl_context = ssl_context
super().__init__(**kwargs)
def init_poolmanager(self, connections, maxsize, block=False):
self.poolmanager = urllib3.poolmanager.PoolManager(
num_pools=connections, maxsize=maxsize,
block=block, ssl_context=self.ssl_context)

with the new setup. If this is true, this code should get deleted and the GET, POST, requests library fetches should be changed do standard calls instead of using this class.

Otherwise LGTM

@quinnwai quinnwai merged commit 073d081 into ohsu-develop May 30, 2024
1 check passed
@lbeckman314 lbeckman314 deleted the bug/ss-testing branch October 1, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants