Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/grip #62

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Feature/grip #62

merged 11 commits into from
Sep 12, 2024

Conversation

matthewpeterkort
Copy link
Collaborator

@matthewpeterkort matthewpeterkort commented Jul 29, 2024 •
edited
Loading

adds grip to ohsu-develop see ACED-IDP/aced_etl_pod#36 for testing instructions

@quinnwai quinnwai self-requested a review July 29, 2024 19:32
quinnwai
quinnwai reviewed Jul 29, 2024
View reviewed changes
Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments, most of them are for my understanding.

helm/grip/templates/NOTES.txt Outdated Show resolved Hide resolved
helm/grip/templates/ingress.yaml Outdated Show resolved Hide resolved
helm/mongodb/Chart.yaml Show resolved Hide resolved
helm/revproxy/gen3.nginx.conf/local-grip.conf Outdated Show resolved Hide resolved
helm/guppy/templates/guppy_config.yaml Show resolved Hide resolved
@matthewpeterkort matthewpeterkort mentioned this pull request Aug 15, 2024
Merged
quinnwai
quinnwai reviewed Aug 16, 2024
View reviewed changes
Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal TODO comments, mostly a main one on scope etc

helm/gen3/Chart.yaml Show resolved Hide resolved
helm/grip/README.md Show resolved Hide resolved
helm/grip/templates/ingress.yaml Outdated Show resolved Hide resolved
helm/grip/values.yaml Show resolved Hide resolved
helm/grip/values.yaml Show resolved Hide resolved
helm/mongodb/Chart.yaml Show resolved Hide resolved
helm/mongodb/Chart.yaml Show resolved Hide resolved
quinnwai
quinnwai previously approved these changes Aug 22, 2024
View reviewed changes
Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed, see details on ticket here, lgtm

@matthewpeterkort matthewpeterkort mentioned this pull request Aug 26, 2024
Open
quinnwai
quinnwai approved these changes Sep 12, 2024
View reviewed changes
Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewpeterkort matthewpeterkort merged commit 92153ca into ohsu-develop Sep 12, 2024
1 check failed
@matthewpeterkort matthewpeterkort deleted the feature/grip branch September 12, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnwai quinnwai quinnwai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewpeterkort @quinnwai