Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up grip service so that it can be passed to sower #67

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

matthewpeterkort
Copy link
Collaborator

Abstracts grip service envar out of code base and into helm chart. Must add

- name: GRIP_SERVICE_NAME
            valueFrom:
              configMapKeyRef:
                name: grip-values
                key: serviceName

to sower config env var section for it to work.

See updated PRS:
ACED-IDP/submission#32
ACED-IDP/aced_etl_pod#36

Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments! Also, what's the benefit of passing the grip service name through sower? Starting testing atm

helm/grip/templates/deployment.yaml Show resolved Hide resolved
helm/mongodb/values.yaml Outdated Show resolved Hide resolved
@matthewpeterkort
Copy link
Collaborator Author

Added some comments! Also, what's the benefit of passing the grip service name through sower? Starting testing atm

So that if helm changes, the code doesn't break

quinnwai
quinnwai previously approved these changes Sep 18, 2024
Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool vibes

Copy link

@quinnwai quinnwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi hello

@matthewpeterkort matthewpeterkort merged commit 8dc85d0 into ohsu-develop Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants