-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix up grip service so that it can be passed to sower #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments! Also, what's the benefit of passing the grip service name through sower? Starting testing atm
So that if helm changes, the code doesn't break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool vibes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi hello
Abstracts grip service envar out of code base and into helm chart. Must add
to sower config env var section for it to work.
See updated PRS:
ACED-IDP/submission#32
ACED-IDP/aced_etl_pod#36