Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post fit selection from asp path #88

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Post fit selection from asp path #88

merged 3 commits into from
Sep 14, 2024

Conversation

cortner
Copy link
Member

@cortner cortner commented Sep 14, 2024

continuing PR #87

@cortner
Copy link
Member Author

cortner commented Sep 14, 2024

@tinatorabi -- I've changed the interface to a format how I see myself using it. Sorry this resulted in a few changes from your version.

Basically the rationale is that I just want a mechanism to very quickly select from a path in different ways. The warmstart you implemented is actually a really nice idea - my rationale for removing it again was that a user would expect that one can continue the solution process, e.g. extending the length of the path. So I'd rather keep my simpler selection mechanism for now and come back to your idea if it is needed.

Would you be willing to take a brief look and see if you see any problems?

@tinatorabi
Copy link
Collaborator

looks good. :) I agree, I think I have to make some changes to BPDual in the ASP package to allow warm-starting with a pre-computed tracer to extend the path, but it is definitely doable. I'll create a PR there.

@cortner
Copy link
Member Author

cortner commented Sep 14, 2024

ok I'll merge and register and we can add proper warmstarts later

@cortner cortner merged commit 8062ad9 into main Sep 14, 2024
5 checks passed
@cortner cortner deleted the aspselect branch September 14, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants