-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill in init.remote_addr
from front machines
#2256
Comments
F.y.i those are the addresses ACINQs main node (
|
We do preserve the client ip in cluster mode, this is actually due to us using a combination of AWS global accelerator and NLB, which is unfortunately not compatible with client ip preservation. Those ips are not internal ACINQ ips but internal AWS ips. @m-schmoock if you use this uri: We can't fix that from within eclair, this is purely a deployment issue. |
@pm47
|
When running behind a load balancer that doesn't preserve the client source IP address, it doesn't make sense to include the `remote-address` tlv in our `init` message, it will contain an IP address that is completely unrelated to our peer. Fixes #2256
When running behind a load balancer that doesn't preserve the client source IP address, it doesn't make sense to include the `remote-address` tlv in our `init` message, it will contain an IP address that is completely unrelated to our peer. Fixes #2256
When running behind a load balancer that doesn't preserve the client source IP address, it doesn't make sense to include the `remote-address` tlv in our `init` message, it will contain an IP address that is completely unrelated to our peer. Fixes ACINQ#2256
When running in
cluster
mode, we shouldn't return theremote_addr
of one of our front machines, this should be written by the front machines themselves and match the real sender's IP address.See lightning/bolts#917 (comment)
This needs some investigation, maybe there is something else that messes things up (e.g. a load balancer's IP address being reported).
The text was updated successfully, but these errors were encountered: