Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sphinx privacy leak #1247

Merged
merged 3 commits into from
Jan 15, 2020
Merged

Fix Sphinx privacy leak #1247

merged 3 commits into from
Jan 15, 2020

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Dec 10, 2019

This PR fixes two small issues:

@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #1247 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
+ Coverage      77%   77.15%   +0.15%     
==========================================
  Files         142      142              
  Lines        9902     9903       +1     
  Branches      389      392       +3     
==========================================
+ Hits         7625     7641      +16     
+ Misses       2277     2262      -15
Impacted Files Coverage Δ
...src/main/scala/fr/acinq/eclair/crypto/Sphinx.scala 100% <100%> (ø) ⬆️
.../scala/fr/acinq/eclair/payment/PaymentPacket.scala 90.9% <100%> (ø) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 50% <0%> (-1.73%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 83.56% <0%> (-0.1%) ⬇️
...nq/eclair/blockchain/electrum/ElectrumWallet.scala 81% <0%> (+0.25%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 92.71% <0%> (+0.71%) ⬆️
...nq/eclair/blockchain/electrum/ElectrumClient.scala 74% <0%> (+0.72%) ⬆️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 96.22% <0%> (+3.77%) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 78.49% <0%> (+4.3%) ⬆️
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala 94.87% <0%> (+5.12%) ⬆️
... and 1 more

@t-bast t-bast marked this pull request as ready for review January 14, 2020 09:20
@t-bast t-bast requested a review from sstone January 14, 2020 09:20
@t-bast t-bast force-pushed the sphinx-privacy-fix branch from a367d10 to 2e18b18 Compare January 14, 2020 09:24
@t-bast t-bast merged commit 102e2a6 into master Jan 15, 2020
@t-bast t-bast deleted the sphinx-privacy-fix branch January 15, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants