-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Bolt 11 parsing spec compliance #1302
Conversation
Correctly implement skipping over hashed tags with invalid length. See lightning/bolts#736.
Codecov Report
@@ Coverage Diff @@
## master #1302 +/- ##
==========================================
+ Coverage 77.52% 78.35% +0.83%
==========================================
Files 144 144
Lines 10098 10756 +658
Branches 390 429 +39
==========================================
+ Hits 7828 8428 +600
- Misses 2270 2328 +58
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have another idea, will try and let you know.
|
||
// @formatter:off | ||
case class UnknownTag0(data: BitVector) extends UnknownTaggedField | ||
case class UnknownTag1(data: BitVector) extends UnknownTaggedField |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
Here is my take: #1308. |
Closing in favor of #1308 |
Add more Bolt 11 spec tests.
Ignore hashed fields with invalid length as the spec requires:
See lightning/bolts#699 and lightning/bolts#736.