-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segregate the node seed from the channel seed #1584
Conversation
- change getSeed signature - change LocalKeyManager signature - implement getSeeds to return both nodeSeed and channelSeed - use separate seeds for node and channels - update README - create NodeKeyManager & ChannelKeyManager - add migration tests Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 87.21% 87.25% +0.03%
==========================================
Files 140 141 +1
Lines 10929 10951 +22
Branches 460 449 -11
==========================================
+ Hits 9532 9555 +23
+ Misses 1397 1396 -1
|
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/crypto/ChannelKeyManager.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
…lKeyManagerSpec Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
4411ebc
to
25d3279
Compare
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move all the *KeyManager
files to a sub-package of crypto
.
Otherwise seems ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tiny nit
11cdaec
to
5f723d3
Compare
Co-authored-by: Pierre-Marie Padiou <pm47@users.noreply.github.com>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Segregate the node seed from the channel seed
We want to have 2 separated seeds:
This PR creates 2 new files,
nodeSeed.dat
&channelSeed.dat
, both stored in$datadir
.Migration from existing setup
This flow is executed twice, for
nodeSeed.dat
andchannelSeed.dat
:The old
seed.dat
is not removed after the migration.