htlc post restart 4

[akumaigorodski]

This is continuation of #1580 (rather than wrestling with git I've decided to send a new PR). It follows suggestions outlined in 9d63b94.

[t-bast]

We're getting close, this time is the right one ;)
Have you been able to test that this correctly gives you the hooks you need for HC?

[t-bast]

What's nice is that now we'll be able to easily add the channelId here! It's not your job to do it in this PR though, I'll do it in a follow-up one.

[akumaigorodski]

Have you been able to test that this correctly gives you the hooks you need for HC?

Yes, getIncomingHtlcs and getHtlcsRelayedOut methods are very close to how it works now (where HC is part of core).

[codecov-io]

Codecov Report

Merging #1586 into master will increase coverage by 0.08%.
The diff coverage is 92.06%.

@@            Coverage Diff             @@
##           master    #1586      +/-   ##
==========================================
+ Coverage   87.25%   87.33%   +0.08%     
==========================================
  Files         145      146       +1     
  Lines       11056    11056              
  Branches      479      471       -8     
==========================================
+ Hits         9647     9656       +9     
+ Misses       1409     1400       -9     

Impacted Files	Coverage Δ
.../src/main/scala/fr/acinq/eclair/PluginParams.scala	0.00% <0.00%> (ø)
...c/main/scala/fr/acinq/eclair/channel/Helpers.scala	96.21% <ø> (-0.07%)	⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala	85.97% <85.00%> (-0.02%)	⬇️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala	90.50% <95.45%> (+1.40%)	⬆️
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala	91.71% <100.00%> (+0.59%)	⬆️
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala	70.96% <100.00%> (ø)
...n/scala/fr/acinq/eclair/channel/ChannelTypes.scala	95.83% <100.00%> (+0.48%)	⬆️
...c/main/scala/fr/acinq/eclair/payment/Auditor.scala	97.82% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala	93.70% <0.00%> (-1.58%)	⬇️
... and 6 more