Improve MPP-send for direct channels #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the recipient is a direct peer, we can use the accurate knowledge of our local channels instead of hard-coded MPP parameters to choose the number of routes and the minimum route amount. This change makes it possible to easily send all local funds in one payment when we're directly connected to the recipient.
pm47
reviewed
Nov 12, 2020
eclair-core/src/main/scala/fr/acinq/eclair/router/RouteCalculation.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/router/RouteCalculation.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
- Coverage 87.31% 87.24% -0.07%
==========================================
Files 146 146
Lines 11056 11060 +4
Branches 471 479 +8
==========================================
- Hits 9653 9649 -4
- Misses 1403 1411 +8
|
pm47
approved these changes
Nov 13, 2020
t-bast
added a commit
that referenced
this pull request
Nov 13, 2020
When the recipient is a direct peer, we can use the accurate knowledge of our local channels instead of hard-coded MPP parameters to choose the number of routes and the minimum route amount. This change makes it possible to easily send all local funds in one payment when we're directly connected to the recipient.
t-bast
added a commit
that referenced
this pull request
Nov 13, 2020
When the recipient is a direct peer, we can use the accurate knowledge of our local channels instead of hard-coded MPP parameters to choose the number of routes and the minimum route amount. This change makes it possible to easily send all local funds in one payment when we're directly connected to the recipient.
t-bast
added a commit
that referenced
this pull request
Nov 13, 2020
When the recipient is a direct peer, we can use the accurate knowledge of our local channels instead of hard-coded MPP parameters to choose the number of routes and the minimum route amount. This change makes it possible to easily send all local funds in one payment when we're directly connected to the recipient.
t-bast
added a commit
that referenced
this pull request
Nov 19, 2020
When the recipient is a direct peer, we can use the accurate knowledge of our local channels instead of hard-coded MPP parameters to choose the number of routes and the minimum route amount. This change makes it possible to easily send all local funds in one payment when we're directly connected to the recipient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the recipient is a direct peer, we can use the accurate knowledge of our local channels instead of hard-coded MPP parameters to choose the number of routes and the minimum route amount.
This change makes it possible to easily send all local funds in one payment when we're directly connected to the recipient.
@dpad85 I'll cherry-pick this commit on the
android-phoenixbranch once this is merged. It made me think that we probably want to change the default (15000 sats, 6 parts) for eclair-mobile MPP: no-one has complained yet, but maybe (1 000 sat, 10) would be better suited for a wallet.