Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channelId to websocket event #1605

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Nov 16, 2020

Thanks to recent changes, the channelId is available in ChannelStateChanged.
We now propagate this information to websocket channel events.

Thanks to recent changes, the channelId is available in ChannelStateChanged.

We now propagate this information to websocket channel events.
@t-bast t-bast requested a review from pm47 November 16, 2020 09:56
@codecov-io
Copy link

Codecov Report

Merging #1605 (be4e485) into master (54b589c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1605      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         146      146              
  Lines       11058    11058              
  Branches      471      471              
==========================================
- Hits         9657     9656       -1     
- Misses       1401     1402       +1     
Impacted Files Coverage Δ
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala 90.00% <0.00%> (-5.00%) ⬇️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 76.98% <0.00%> (-0.80%) ⬇️
...nq/eclair/blockchain/electrum/ElectrumWallet.scala 80.25% <0.00%> (-0.26%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.06% <0.00%> (+0.08%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 95.27% <0.00%> (+1.57%) ⬆️

@t-bast t-bast merged commit a2a980c into master Dec 7, 2020
@t-bast t-bast deleted the channel-id-websocket-events branch December 7, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants