Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Exclude tests that call external APIs #1622

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Nov 30, 2020

These tests have been flaky because external APIs tend to be down or throttle our calls. and we don't want our test suite to fail because of that.

In practice it's enough if developers run these tests locally once in a while.

These tests have been flaky because external APIs tend to be down or throttle
our calls. and we don't want our test suite to fail because of that.

In practice it's enough if developers run these tests locally once in a while.
@t-bast t-bast requested a review from pm47 November 30, 2020 16:55
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick

@t-bast
Copy link
Member Author

t-bast commented Nov 30, 2020

😎

@codecov-io
Copy link

Codecov Report

Merging #1622 (d069af7) into master (8bfb9f0) will decrease coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
- Coverage   87.25%   86.70%   -0.56%     
==========================================
  Files         146      146              
  Lines       11063    11063              
  Branches      503      503              
==========================================
- Hits         9653     9592      -61     
- Misses       1410     1471      +61     
Impacted Files Coverage Δ
...acinq/eclair/blockchain/watchdogs/Monitoring.scala 0.00% <0.00%> (-100.00%) ⬇️
...q/eclair/blockchain/watchdogs/HeadersOverDns.scala 16.66% <0.00%> (-60.42%) ⬇️
...acinq/eclair/blockchain/fee/BitgoFeeProvider.scala 58.33% <0.00%> (-37.51%) ⬇️
...lair/blockchain/watchdogs/BlockchainWatchdog.scala 60.00% <0.00%> (-35.00%) ⬇️
...cinq/eclair/blockchain/watchdogs/ExplorerApi.scala 54.28% <0.00%> (-34.29%) ⬇️
.../eclair/blockchain/fee/EarnDotComFeeProvider.scala 70.37% <0.00%> (-29.63%) ⬇️
...clair/blockchain/electrum/ElectrumClientPool.scala 78.49% <0.00%> (-1.08%) ⬇️
...nq/eclair/blockchain/electrum/ElectrumClient.scala 73.52% <0.00%> (+0.36%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 77.77% <0.00%> (+0.79%) ⬆️
...main/scala/fr/acinq/eclair/router/Validation.scala 92.91% <0.00%> (+1.49%) ⬆️
... and 1 more

@t-bast t-bast merged commit 6330e76 into master Nov 30, 2020
@t-bast t-bast deleted the external-api-test-tag branch November 30, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants