Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync fix #1624

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Sync fix #1624

merged 2 commits into from
Dec 7, 2020

Conversation

akumaigorodski
Copy link
Contributor

Make ReplyShortChannelIdsEnd low priority in TransportHandler, otherwise it is often sent before the related bunch of gossip messages is done transmitting which breaks sync logic for remote peers.

@akumaigorodski
Copy link
Contributor Author

Does it make sense to make the whole RoutingMessage trait as low priority instead of just those 4 subtypes?

@pm47
Copy link
Member

pm47 commented Dec 7, 2020

Hi Anton, great find! Does this solve your sync issue?

Does it make sense to make the whole RoutingMessage trait as low priority instead of just those 4 subtypes?

Maybe, but need to double check for AnnouncementSignatures.

@akumaigorodski
Copy link
Contributor Author

Does this solve your sync issue?

Yes, it does.

pm47
pm47 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acking as-is, because this change is small, testing this is hard and the risk of a regression is small.

@pm47 pm47 merged commit 8cfa3f5 into ACINQ:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm47 pm47 pm47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akumaigorodski @pm47