Use TlvStream for encrypted channel backup #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support extensions to standard LN messages, we must put our custom fields in a TlvStream. The only field that didn't respect that was the encrypted channel backup. We also fix a bug where we didn't send our backup in `shutdown` messages.
sstone
requested changes
Apr 26, 2021
src/commonTest/kotlin/fr/acinq/lightning/wire/LightningCodecsTestsCommon.kt
Outdated
Show resolved
Hide resolved
sstone
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support extensions to standard LN messages, we must put our custom fields in a
TlvStream.The only field that didn't respect that was the encrypted channel backup.
This change is a required preliminary step to be able to implement lightning/bolts#847
We also fix a bug where we didn't send our backup in
shutdownmessages.