Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Data Type Representation indeed need a Version? #108

Open
knelson-farmbeltnorth opened this issue Jul 20, 2023 · 6 comments
Open

Does Data Type Representation indeed need a Version? #108

knelson-farmbeltnorth opened this issue Jul 20, 2023 · 6 comments

Comments

@knelson-farmbeltnorth
Copy link
Contributor

Version requires that any id of a Representation is compound, with Code & Version. Do we intend to version the codes often enough to make the complexity worthwhile?

@knelson-farmbeltnorth
Copy link
Contributor Author

@zwing99 has proposed that we version the entire collection of Representations using semantic versioning. As such, we would carry a single Representation version number across the entire Application Data Model. Data consumers would simply reference the appropriate version of the codes. As such, we could remove the version from each Representatation. @strhea and I like the solution. @aferreyra what are your thoughts?

@zwing99
Copy link
Collaborator

zwing99 commented Sep 20, 2023

@zwing99 has proposed that we version the entire collection of Representations using semantic versioning. As such, we would carry a single Representation version number across the entire Application Data Model. Data consumers would simply reference the appropriate version of the codes. As such, we could remove the version from each Representatation. @strhea and I like the solution. @aferreyra what are your thoughts?

Yes, please version them as one!

@aferreyra
Copy link
Collaborator

aferreyra commented Sep 20, 2023 via email

@knelson-farmbeltnorth
Copy link
Contributor Author

As a recommendation, I've attached a Data Type Representation Version to the Root of the model, with the definition "Version identifier of the Data Type Representations used throughout the model. If omitted, the current version is assumed."

image

@strhea
Copy link

strhea commented Sep 27, 2023

Works for me!

@knelson-farmbeltnorth
Copy link
Contributor Author

Agreement in 27 September 2023 meeting to implement as proposed, as well as implementing a similar attribute for Unit System version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants