Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 sha256 incorrect in google chrome #123

Merged

Conversation

potter-sun
Copy link
Contributor

Google Chrome 115.0.5790.102 produces incorrect SHA-256 hashes

When js-sha256 is used in chrome, there will be occasional problems in generating hash. Refer to the following method to use @aws-crypto/sha256-js

reference link: emn178/js-sha256#40

@vizipi
Copy link

vizipi bot commented Aug 30, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % AbigailDeng 57 14
28.57 % lhoopox 2 4

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 98.79%[yarn.lock]
  • 0.00%[src/index.js]
  • 97.57%[dist/aelf.umd.js]
  • 0.00%[test/e2e/wallet.test.js]
  • 68.02%[src/util/bloom.js]
  • 80.97%[src/util/utils.js]
  • 95.95%[dist/aelf.cjs.js.map]
  • 99.60%[package.json]
  • 97.57%[dist/aelf.cjs.js]
  • 95.95%[test/unit/chain/index.test.js]
  • @vizipi vizipi bot requested review from AbigailDeng and lhoopox August 30, 2023 03:59
    @AbigailDeng AbigailDeng merged commit f1a779c into AElfProject:feature/test-chain-util-workflow Aug 30, 2023
    1 check passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants