Update pyo3 crate to 0.18.3 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the build failure is due to nautilus depending on pyo3 0.17 still. There is a PR over there to update to 0.18.2, but it doesn't look like the maintainers have touched the project in a while. Commenting out the grammartec dependency in Cargo.toml as well as the nautilus and AGPL features. I was able to get this to build. I'm not terribly proficient in Cargo so I'm unsure what the correct way to solve this is. |
|
@andreafioraldi is a maintainer |
|
nautilus 0.3.1 released with the updated pyo3 |
|
it seems good |
|
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.