Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibAFL_qemu: Disable Capstone to fix build issues on some distributions #1263

Merged
merged 1 commit into from
May 11, 2023
Merged

LibAFL_qemu: Disable Capstone to fix build issues on some distributions #1263

merged 1 commit into from
May 11, 2023

Conversation

intrigus-lgtm
Copy link
Contributor

No description provided.

@intrigus-lgtm
Copy link
Contributor Author

Potentially we want to add a --disable-capstone ħere as well. (See https://discord.com/channels/736989425770168422/850283052773015573/1103712526652420167)

@domenukk
Copy link
Member

domenukk commented May 9, 2023

@andreafioraldi any drawbacks if we disable capstone always?

@domenukk domenukk changed the title Improve argument order LibAFL_qemu: Disable Capstone to fix build issues on some distributions May 11, 2023
@domenukk domenukk merged commit 91b10f8 into AFLplusplus:main May 11, 2023
@intrigus-lgtm
Copy link
Contributor Author

@domenukk the PR title is wrong!
This does not actually fix the problem, it just reorders/sorts the arguments.
To fix this, we would have had to disable capstone here as well which did not happen.

@domenukk
Copy link
Member

Ok sorry :D Also seems to still fail on some distros.

@intrigus-lgtm intrigus-lgtm deleted the patch-1 branch June 12, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intrigus-lgtm @domenukk