Add check for if mutations were skipped to MutationalStages #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisoncrump
changed the title
|
I didn't add a case for StdPushMutationalStage; not quite sure how to do so. |
|
No idea why this causes concolic and macOS to fail... seems to be GH's side: https://www.githubstatus.com/ |
|
Can we fuzzbench this change? |
|
I did so -- seems to be a marginal improvement for fast targets, stronger for slow targets, as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutations may not actually be performed on the input, in which case the mutator will return MutationResult::Skipped. We should not execute mutants which have no difference from the parent. This especially affects slow-executing targets.