Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libafl_cc: add override env vars #1310

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Conversation

s1341
Copy link
Collaborator

@s1341 s1341 commented Jun 8, 2023

Allow one to specify the LLVM_BINDIR, LLVM_VERSION, LLVM_CXXFLAGS, and LLVM_LDFLAGS environment variables when building libafl_cc, in order to allow one to override the values returned by llvm-config, or for cases where llvm-config is not available.

@s1341 s1341 force-pushed the libafl_cc_add_override_env_vars branch from 8b262e0 to 4540597 Compare June 8, 2023 16:01
@s1341 s1341 changed the base branch from libfuzzer to main June 8, 2023 16:01
@s1341
Copy link
Collaborator Author

s1341 commented Jun 8, 2023

ok. Rebased to main.

&& llvm_cxxflags.is_ok()
&& llvm_ldflags.is_ok()
&& llvm_version.is_ok())
{
println!(
"cargo:warning=Failed to find llvm-config, we will not build LLVM passes. If you need them, set the LLVM_CONFIG environment variable to a recent llvm-config."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add additional info to the warning then?

@domenukk domenukk merged commit 751d96f into main Jun 9, 2023
@domenukk domenukk deleted the libafl_cc_add_override_env_vars branch June 9, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants