-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ForkserverBytesCoverageSugar to use parse_afl_cmdline #1343
update ForkserverBytesCoverageSugar to use parse_afl_cmdline #1343
Conversation
I think we should also use: .is_deferred_frksrv(true)
.is_persistent(true)
.autotokens(&mut tokens) |
Also it should use
|
If we move the sugar wrapper to use
|
libafl_sugar/src/forkserver.rs
Outdated
@@ -177,17 +173,33 @@ impl<'a, const MAP_SIZE: usize> ForkserverBytesCoverageSugar<'a, MAP_SIZE> { | |||
ForkserverExecutorBuilder::new() | |||
.program(self.program.clone()) | |||
.parse_afl_cmdline(self.arguments) | |||
.is_deferred_frksrv(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tokatoka pointed out that this won't work for some targets, so it's better to not use deferred forkserver by default here (afl++ solves this by scanning the binary, but we don't want to do that imho)
I didn't look into it, so not sure? |
once all the tests run, i think this is ready for a look. I tested it without the generic / with the build_dynamic using exercise-3 (which uses ASAN and a map size of 86217) and it worked. |
Looks good, thanks! <3 |
Updates
ForkserverBytesCoverageSugar
to useparse_afl_cmdline
when usingForkserverExecutorBuilder
to create aForkserverExecutor
.The current impl uses
args
which don't account for"@@"
.