Fix build/clippy errors and update CASR #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisoncrump
changed the title
domenukk
reviewed
Jul 24, 2023
| @@ -7,6 +7,7 @@ | |||
| allow(clippy::useless_conversion) | |||
| )] | |||
| #![allow(clippy::needless_pass_by_value)] | |||
| #![allow(clippy::needless_pass_by_ref_mut)] | |||
There was a problem hiding this comment.
That's a false positive? Always?
There was a problem hiding this comment.
In libafl_qemu, it is at multiple points. I'll make this statement-level allows.
|
Somehow the fuzzers on ubuntu don't work? |
Yeah I have no idea on this one chief 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a few missing imports from CASR components. Upstream, this should be fixed by making sure the macro itself explicitly refers to the items it uses, but we can fix this downstream for now.
Otherwise, clippy is mad again.