Fix UB in frida fuzzers #1385
Merged
Fix UB in frida fuzzers #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this lint is very noisy, and adding #[must_use] to _all_ (even pure )functions seems very excessive to me
Mrmaxmeier
force-pushed
the
fix-and-update-frida-fuzzers
branch
from
3cc46b5 to
6a38637
Compare
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab at #1383. Will probably take a few CI cycles though..
This includes an update offrida-gum(and addresses capstone compat issues), but I'll probably split the PR into two later.The changes to
FridaInstrumentationHelperneccessitate API breakage (&-references toRef). In case some of the existing (unused) APIs are not needed, removing them would probably simplify the code a lot. (i.e. if we don't allow changing instrumentation ranges after the fact, there's no need to reference count the ranges tree.)Fixes #1383, unblocks #1053.