write_minibsod apple implementation proposal. #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
minibsod_macos
branch
from
2e9ef17 to
6b79e57
Compare
|
Awesome! :) |
addisoncrump
pushed a commit
that referenced
this pull request
Aug 22, 2023
|
@devnexen what platform was this written for? It looks like it never really worked (see #2154) |
|
I'd say replacing target_env by target_vendor here would be appropriate ? |
|
Yes but then it doesn't build at least on M1 Mac |
|
Yes I think the libc crate had moved out mach api to the mach crate. Fixing .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.