-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for publishing libafl_libfuzzer #1457
Conversation
Woot woot! |
))] | ||
#![cfg_attr(test, deny( | ||
missing_debug_implementations, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not checked in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I thought it was but apparently somehow missed.
error: item in documentation is missing backticks
--> libafl_libfuzzer/src/lib.rs:5:12
|
5 | //! To use LibAFL in place of libfuzzer, change the following line in your fuzz/Cargo.toml:
| ^^^^^^ |
@@ -1,5 +1,68 @@ | |||
//! `libafl_libfuzzer` offers a "permanent" replacement for the now-deprecated libfuzzer | |||
//! | |||
//! ## Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to copy&paste this into the book as well? might make sense (or include it from there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe it's too technical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too technical. Makes sense to include it since many folks might be coming from libfuzzer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What section should it be put under? Its own? It can be used with both C/C++ and Rust targets but needs different setups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure sounds like an extra section to me
This wraps up some last minute items to prepare the publishing of libafl_libfuzzer.