Scalability introspector + State refactor #1674
Conversation
…AFL into scalability_introspector
tokatoka
changed the title
| @@ -113,7 +113,7 @@ impl LibfuzzerCrashCauseFeedback { | |||
|
|
|||
| impl<S> Feedback<S> for LibfuzzerCrashCauseFeedback | |||
| where | |||
| S: UsesInput<Input = BytesInput> + HasClientPerfMonitor, | |||
There was a problem hiding this comment.
I don't understand why this code compiles...?
@addisoncrump
Essentially we changed UsesInput to State.
But in UsesInput you can force(?) its Input to be BytesInput.
Now we're using State but it doesn't know anything about Input type.
Why this works????
There was a problem hiding this comment.
State<Input = BytesInput>
There was a problem hiding this comment.
ok. it just compiles..
but why syntax like this works?
State<Input = BytesInput>
Shouldn't this Input be a associate type of State?
but the trait State is this:
pub trait State:
UsesInput + Serialize + DeserializeOwned + MaybeHasClientPerfMonitor + MaybeHasScalabilityMonitor
{
}
And there's no such thing like Input in this State definition
There was a problem hiding this comment.
My question is what is this Input for the State
| @@ -82,10 +82,7 @@ impl<'a, S> Named for NautilusFeedback<'a, S> { | |||
|
|
|||
| impl<'a, S> Feedback<S> for NautilusFeedback<'a, S> | |||
| where | |||
| S: HasMetadata | |||
There was a problem hiding this comment.
Same pattern is in here..?
Would this be a problem?
There was a problem hiding this comment.
This one is fine -- anywhere you see <Input = ...> automatically gets flattened out to UsesInput's Input.
No description provided.