Remove capstone from frida [x86_64] #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's not done but, almost |
s1341
reviewed
Dec 13, 2023
libafl_frida/src/asan/asan_rt.rs
Outdated
| 41 => (Some(18), Some(64)), | ||
| fn register_idx(&self, reg: X86Register) -> (Option<u16>, Option<u16>) { | ||
| match reg { | ||
| X86Register::Eax => (Some(0), Some(32)), |
There was a problem hiding this comment.
Maybe make this return a Some((u16, u16))?
libafl_frida/src/asan/errors.rs
Outdated
| { | ||
| let insns = disas_count( | ||
| &decoder, | ||
| unsafe { std::slice::from_raw_parts(start_pc as *mut u8, 4 * 11) }, |
There was a problem hiding this comment.
perhaps we should increase the 4 here to 16 (which is close enough to the limit of a single instruction IIRC), and then only display the first 11 instructions?
Merged
|
if this is resolved then good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.