Add several warnings when starting forkserver #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Feb 22, 2024
| } | ||
|
|
||
| if env::var("__AFL_SHM_ID").is_err() { | ||
| log::warn!("__AFL_SHM_ID not set. It is necessary to set this env, otherwise the forkserver cannot communicate with the fuzzer"); |
There was a problem hiding this comment.
I don't get it, isn't this set by the executor?
There was a problem hiding this comment.
no at the moment it is set by user in the fuzzer's code not in executor
There was a problem hiding this comment.
the forkserver does/can not hold the shmem. (i remember it was because of more than 1 mut ref).
The shmemprovider forkserver holds is used for passing input over shmem and NOT for the coverage map
There was a problem hiding this comment.
It needs to be a return Err(Error::IllegalState(..)) in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.