Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransferFeedback for determining if a testcase was from another node #1906

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

addisoncrump
Copy link
Collaborator

This is useful for short-circuiting potentially expensive objective feedbacks, as well as for creating nodes which just perform analysis on inputs rather than actually fuzzing.

@addisoncrump
Copy link
Collaborator Author

Seeing as how this adds two branches in a non-fast path, I'm going to merge this as is. Revert if there are any major concerns with this change, please.

@addisoncrump addisoncrump merged commit f3c37db into main Mar 4, 2024
26 checks passed
@addisoncrump addisoncrump deleted the transfer-observer branch March 4, 2024 14:33
@tokatoka
Copy link
Member

tokatoka commented Mar 5, 2024

i think this could have been simply a field in Testcase

@domenukk
Copy link
Member

domenukk commented Mar 5, 2024

Probably a good idea for performance reasons

@addisoncrump
Copy link
Collaborator Author

That doesn't work, because we need this information at evaluation time.

@domenukk
Copy link
Member

domenukk commented Mar 5, 2024

Then, should be a state-flag in the state?

@addisoncrump
Copy link
Collaborator Author

Potentially so? HasTransferState?

@domenukk
Copy link
Member

domenukk commented Mar 5, 2024

More a status than a state? State seems a bit overused in a struct called StdState implementing a trait called state :D

@tokatoka
Copy link
Member

tokatoka commented Mar 6, 2024

Let's just allow hooks in handle_in_client?

@domenukk
Copy link
Member

domenukk commented Mar 6, 2024

sound fun

@tokatoka
Copy link
Member

tokatoka commented Mar 7, 2024

I made a POC in #1916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants