Add recv_blocking_with_flags #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisoncrump
force-pushed
the
llmp-blocking-recv-flags
branch
from
d115efe to
d51a4af
Compare
domenukk
reviewed
Apr 25, 2024
| /// Receive the buffer, also reading the LLMP internal message flags | ||
| #[allow(clippy::type_complexity)] | ||
| #[inline] | ||
| pub fn recv_buf_blocking_with_flags(&mut self) -> Result<(ClientId, Tag, Flags, &[u8]), Error> { |
There was a problem hiding this comment.
Instead of allowing type_complexity, maybe it's time for a struct?
There was a problem hiding this comment.
Sure, let's include that change in #2068?
|
Am I good to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a blocking version of
recv_buf_with_flagsto both the llmp receiver and client. This allows for easier creation of external LLMP clients.