Restrict more on edges map API #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokatoka
changed the title
tokatoka
commented
Apr 26, 2024
| @@ -692,7 +692,7 @@ where | |||
| pub extern "C" fn trace_block_transition_hitcount(_: *const (), id: u64) { | |||
| unsafe { | |||
| PREV_LOC.with(|prev_loc| { | |||
| let x = ((*prev_loc.get() ^ id) as usize) & (EDGES_MAP_PTR_NUM - 1); | |||
There was a problem hiding this comment.
@rmalmain
can you check these are correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow the use of std_edges_map_observer unless it is using sancov backend.
This is because std_edges_map_observer relies on edges_max_num. However edges_max_num() will only set to be the real number of edges in the target only if you are using the sancov backend.
If it is used without this prerequisite, then it is wrong