Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qemu runtime defs for aarch64 #2151

Merged
merged 1 commit into from
May 12, 2024

Conversation

twizmwazin
Copy link
Contributor

This fixes the "bindings generation" reported in #2128. It is a shot in the dark: this is enough to make it compile (or reach the other error in that issue), but I don't know for sure it is correct nor do I know how to properly test it. I would advise someone to test this, or at least someone more familiar with the code and calling conventions should review it before assuming it is correct.

This file also caused libafl_qemu_stub_bindings.rs to update after rebuilding. Should I commit the changes in that file? If the file is autogenerated, should it be ignore by git altogether?

@domenukk domenukk requested a review from rmalmain May 7, 2024 14:20
@rmalmain
Copy link
Collaborator

Thank you for the PR.

I'll think of a way to reduce the generations of the binding files, it is fine if you do not commit it.
i was experimenting if it was realistic always to generate them, but it seems it has slight differences depending on the compiler used, causing it to be often regenerated even when it's useless.

@rmalmain rmalmain merged commit 3328f06 into AFLplusplus:main May 12, 2024
102 checks passed
riesentoaster pushed a commit to riesentoaster/LibAFL that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants