Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strum requirement from 0.25 to 0.26 #2173

Closed
wants to merge 4 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 13, 2024

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

---
updated-dependencies:
- dependency-name: strum
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 13, 2024
@domenukk
Copy link
Member

domenukk commented May 13, 2024

Breaking Changes
...
The Iterator struct generated by EnumIter now has new bounds on it. This shouldn't break code unless you manually added the implementation in your code.

See
https://github.com/Peternator7/strum/blob/master/CHANGELOG.md#0260

@domenukk
Copy link
Member

The error is:

error[E0277]: the trait bound `arch::x86_64::RegsIter: std::iter::FusedIterator` is not satisfied
   --> libafl_qemu/src/arch/x86_64.rs:13:63
    |
13  | #[derive(IntoPrimitive, TryFromPrimitive, Debug, Clone, Copy, EnumIter)]
    |                                                               ^^^^^^^^
    |                                                               |
    |                                                               the trait `std::iter::FusedIterator` is not implemented for `arch::x86_64::RegsIter`
    |                                                               in this derive macro expansion
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/strum_macros-0.25.3/src/lib.rs:378:1
    |
378 | pub fn enum_iter(input: proc_macro::TokenStream) -> proc_macro::TokenStream {
    | --------------------------------------------------------------------------- in this expansion of `#[derive(EnumIter)]`
    |
note: required by a bound in `strum::IntoEnumIterator::Iterator`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/strum-0.26.2/src/lib.rs:105:11
    |
101 |     type Iterator: Iterator<Item = Self>
    |          -------- required by a bound in this associated type
...
105 |         + FusedIterator;
    |           ^^^^^^^^^^^^^ required by this bound in `IntoEnumIterator::Iterator`

Second error:

error[E0599]: no variant or associated item named `iter` found for enum `libafl_qemu_sys::MmapPerms` in the current scope
  --> libafl_qemu/src/lib.rs:95:30
   |
95 |     for r in sys::MmapPerms::iter() {
   |                              ^^^^ variant or associated item not found in `MmapPerms`
   |
   = help: items from traits can only be used if the trait is in scope
help: trait `IntoEnumIterator` which provides `iter` is implemented but not in scope; perhaps you want to import it
   |
31 + use strum::IntoEnumIterator;
   |

@domenukk
Copy link
Member

@rmalmain want to take a look if that somehow works locally? (I'm on MacOS right now :D )

@rmalmain
Copy link
Collaborator

@domenukk should be fixed

@domenukk
Copy link
Member

Fixed with #2173

@domenukk domenukk closed this May 18, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 18, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/strum-0.26 branch May 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants