Address comments from #2302 #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
commented
Jun 18, 2024
|
|
||
| // # Safety | ||
| // The `multi_machine_receiver_hook` needs messages to outlive the receiver. | ||
| // The underlying memory region for incoming messages lives longer than the async thread processing them. |
There was a problem hiding this comment.
@rmalmain Are we sure this is the case? Is there any race condition when memory gets cleared up before the async thread kicks in?
There was a problem hiding this comment.
afaik the messages live long enough. i'll double check this
|
@rmalmain can you take a look if you're happy with these changes? |
|
@domenukk looks good to me, thanks for cleaning up |
tokatoka
reviewed
Jun 18, 2024
| // We start ourself as child process to actually fuzz | ||
| let (staterestorer, _new_shmem_provider, core_id) = if env::var(_ENV_FUZZER_SENDER).is_err() | ||
| { | ||
| let broker_things = |mut broker: TcpEventBroker<S::Input, MT>, _remote_broker_addr| { |
There was a problem hiding this comment.
this is not really working for remote host...
this is the only place that remote_broker_addr is every passed, and it completely ignores the address
There was a problem hiding this comment.
Yes would be good to fix it at some point
R9295
pushed a commit
to R9295/LibAFL
that referenced
this pull request
Jun 21, 2024
* Address comments from AFLplusplus#2302 * secure? * cleanup * early exit ftw * address clippy * Fix all the things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of smaller cleanups addressing my comments in PR #2302